RC-1

RC-1 Purpose & Guidelines

authorkmao, Jed, Kain
statusImplemented
created2023-12-15
updated2023-05-13
implemented2023-12-16

What is a Release Candidate??

A Release Candidate (RC) is a document that outlines a bundle of proposed changes for approval by the Infinex Council. An RC can only be written by an established Working Group (WG), and each WG has a set cadence of RCs they need to follow.

RC Rationale

Infinex's initial governance structure was forked from Synthetix and thus established XIPs as the sole method to approve and implement changes to the protocol. After further developments, various issues have arisen. These are:

  • The lack of independence granted to WGs, and additional cumbersome processes for the council.
  • Governance overhead and inefficiencies with XIPs, especially for smaller upgrades.
  • The wide and consistent range of protocol updates makes it impossible to document effectively with XIPs.

In addition to the protocol (which refers to the smart contracts of Infinex), the scope of Infinex also includes the app (front-end code that runs in the user's browser) and platform (back-end code and databases) which have subtly different requirements and processes for release, migration, and rollback.

The introduction of RCs is designed to resolve these issues, allowing for easier approval processes for upgrades and changes to Infinex, while ensuring that the Infinex Council is the sole decision-making body for all protocol, app and platform code changes.

The following implementations are proposed:

  1. The introduction of Release Candidates as an alternative approval process for less critical items that do not require a XIP. Release candidates can only be written by WGs.
  2. The need for RCs by WGs on a timely basis, with their cadence specified by the WG's Charter.
  3. The ability to post emergency RCs, which can be voted on outside the specified cadence of RCs, at the discretion of the council and the working groups.

RC Workflow

Only a member of an established Working Group can submit a Release Candidate. Release candidates will be posted publicly via the Infinex Proposals website, but do not require a public presentation within the community before the council can approve them. It is up to the council and WG's discretion to communicate the proposed changes internally for approval by the council.

An RC's workflow will differ from the XIP's workflow as an RC seeks approval to deploy work that has already been done. This work may be work that the WG has found on their own (bug fixes, upgrades), or work that has been delegated from an approved XIP. XIPs, will instead seek approval to begin work or implementation of a specific spec.

The RC workflow comprises three main stages.

1. Pre-Draft

Prior to the draft, the associated WG will develop a variety of changes, which they will bundle in an RC. Before each RC is published, the Legal Working Group must conduct a review of the RC.

2. Draft

After the WG is ready to deploy their changes, they will post an RC marked as a Draft. It must then meet specific formatting criteria (largely, correct metadata in the header and structure), and be approved by the Proposals Editor before it can be proposed to the Infinex Council.

3. Voting

Once a Draft is believed to be mature enough and ready to progress, it will move into Vote Pending. This stage will usually involve internal discussions between the WG and the council to correct the RC (if required).

4. Approval

RCs will be voted on by the Infinex Council (Vote Pending) for five days and will be passed with a majority vote. Approved RCs are then moved to Approved and then Implemented once Implemented. Otherwise, it is Rejected.

RC status terms

  • Draft – The initial state of a new RC before the Infinex Council has formally assessed it.
  • Vote Pending – an RC that is awaiting a vote.
  • Approved – an RC that has successfully reached a majority Infinex Council vote in favour.
  • Rejected – an RC that has failed to reach a majority Infinex Council vote in favour.
  • Reverted – an RC that has been rolled back.
  • Implemented – an RC has been implemented.

What belongs in a successful RC?

Each RC should have the following parts:

  • Overview - The overview should aim to describe a summary and motivation for the changes proposed in the RC.
  • Outcome - The goals which, when achieved, mean the RC has been implemented successfully.
  • Proposed Changes – Description of proposed changes and/or upgrades expected to achieve the outcome. These should be tagged with the areas they involve, including:
    • Frontend changes (e.g. deploying a new route or developing components)
    • Backend changes (e.g. updating APIs or database structure)
    • Smart contract changes (e.g. smart accounts)*
    • Design and branding changes (e.g. font change)
    • Marketing changes (e.g. new marketing campaign)
    • Maintenance, including bug fixes, optimisations, or dependency upgrades (e.g updating the version of a library)
    • Operational changes, i.e. anything related to the operational processes of Infinex and its contributors
  • Appendices and Supporting Documents (if applicable) – Any additional documents or data supporting the RC.

*Smart contract changes are expected to be included in XIPs primarily.

A relevant concern around this model is the ambiguity surrounding which changes require a XIP, or instead can be bundled in RCs. As such, the criteria for determining whether the proposed change requires a XIP would be as follows:

  1. The change does not interact with the user's smart account.
  2. The change does not restrict a user's access to the platform.
  3. The change does not directly involve user funds.
  4. The change is not a parameter change.

If all the above statements are true, then the change may be bundled in an RC.

Here are hypothetical examples of features that would require an XIP versus those that would not:

Requires a XIPCan be bundled in an RC
Spot trading implementationTwitter integration
Aave lending integrationAdding desktop notification functionality
Upgrading a user's smart accountChanging the global font of Infinex to Comic Sans
Changing a parameter within the Infinex Accounts smart contractUpdating the wallet interface
Changing how user accounts are stored or handledChanging the onboarding flow based on user feedback

RC Header Preamble

title:

id: <the number associated with RC, each RC will have a unique number>

wg: <the associated WG that has released this RC>

author: <a list of the author's or authors' name(s) and/or username(s), or name(s) and email(s)>

status: <Draft | Vote Pending | Approved | Rejected | Executed>

released: <yyyy-mm-dd>

implemented: <yyyy-mm-dd>

Proposals Editor Responsibilities

As clarified in XIP-4 the Proposals Editor will manage future proposal templates. The Proposals Editor also has additional responsibilities for RCs.

During the drafting stage of the process, the Proposals Editor is responsible for working with the RC author to:

  • Ensure the title accurately describes the content.
  • Read the RC to check if it is ready: sound and complete. The ideas must make technical sense, even if they don't seem likely to get to final status.
  • Check the RC for language (spelling, grammar, sentence structure, etc.), markup (Markdoc), and code style.

If the RC isn't ready, the editor will send it back to the author for revision, with specific instructions.

Once the RC is ready for the repository, the Proposals Editor will:

  • Assign an RC number (generally the PR number or, if preferred by the author, the Issue # if there was discussion in the Issues section of this repository about this RC).
  • Merge the corresponding pull request.
  • Send a message back to the RC author with the next step.

The Proposals Editor does not pass judgment on RCs. They merely hold an administrative and editorial role.

Copyright

Copyright and related rights waived via CC0.

Contribute to Proposals on GitHub